Skip to content

Remove the lint script that could never run - #8

Open
arnelirobles wants to merge 1 commit into
mainfrom
fix/1-remove-lint-script
Open

arnelirobles wants to merge 1 commit into
mainfrom
fix/1-remove-lint-script

Conversation

@arnelirobles

@arnelirobles arnelirobles commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Removes the lint script from package.json. It could never run (no eslint config, no TypeScript parser), so it read as a quality gate that does not exist. Type checking already runs in CI.

If real linting is wanted later, it should come with a config and a CI step in one change.

Fixes #1

Summary by CodeRabbit

  • Chores
    • The lint command is no longer available among the project’s standard commands. Other commands and package settings remain unchanged.
    • No end-user-facing features or behavior changes are included in this update. There are no additional user-visible updates to report.

It called eslint with no config and no TypeScript parser, so it failed for everyone. Type checking already runs in CI through tsc.
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The lint script was removed from package.json. Other scripts and package settings remain unchanged.

Changes: Package scripts

Layer / File(s) Summary
Remove lint script
package.json
The manifest no longer declares the lint script that ran ESLint on package source directories.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: Minimal · up to a4b37

This change removes a non-functional lint script and does not alter runtime behavior. It is safe to merge.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the nonfunctional lint script from package.json.
Linked Issues check Passed Issue #1 allows removing the non-working lint script. The whole-PR diff removes lint from the root package.json and leaves the remaining scripts unchanged. The reviewed tree contains no separate…
Out of Scope Changes check Passed The whole-PR diff changes only the root package.json by removing the lint script. This change directly implements issue #1 and contains no unrelated code or configuration changes.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check

Explanation

Issue #1 allows removing the non-working lint script. The whole-PR diff removes lint from the root package.json and leaves the remaining scripts unchanged. The reviewed tree contains no separate feed-slurp package or manifest, so no second copy is present for this PR to update.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f0bf1bb-d0a9-4ce1-b5af-8fc0f678b8a8
Commits

Reviewing files that changed from the base of the PR and between 8c498e3 and a4b37c9.

Files selected for processing: 1

  • package.json
Files with no reviewable changes: 1

  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The lint script fails: eslint is not a dependency

1 participant